Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(components): adjust BaseDeck styling #14219

Merged

Conversation

brenthagen
Copy link
Contributor

Overview

adjusts BaseDeck styling of slot labels, staging area slot clip positioning, and colors to match design system deck map

Screen Shot 2023-12-15 at 1 43 08 PM

https://www.figma.com/file/1ot18My22DALIcjdLl5LJh/Helix-Design-System?type=design&node-id=358-31898&mode=design&t=NPg8Vpfv7bU3KbWK-4

closes RAUT-902, RAUT-861

Test Plan

  • visually check positioning match to figma

Changelog

  • Adjusts BaseDeck styling

Review requests

check vs. figma

Risk assessment

low

adjusts BaseDeck styling of slot labels, staging area slot clip positioning, and colors to match
design system deck map

closes RAUT-902, RAUT-861
@brenthagen brenthagen requested a review from a team as a code owner December 15, 2023 18:54
@brenthagen brenthagen requested review from a team and jerader and removed request for a team and jerader December 15, 2023 18:54
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Merging #14219 (5be8873) into chore_release-7.1.0 (9a3065f) will decrease coverage by 0.09%.
Report is 5 commits behind head on chore_release-7.1.0.
The diff coverage is 12.50%.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-7.1.0   #14219      +/-   ##
=======================================================
- Coverage                70.41%   70.33%   -0.09%     
=======================================================
  Files                     1636     2513     +877     
  Lines                    54502    71521   +17019     
  Branches                  4030     9124    +5094     
=======================================================
+ Hits                     38378    50304   +11926     
- Misses                   15424    18996    +3572     
- Partials                   700     2221    +1521     
Flag Coverage Δ
app 67.28% <ø> (+28.56%) ⬆️
components 59.67% <14.28%> (-0.06%) ⬇️
labware-library 51.50% <ø> (ø)
protocol-designer 45.01% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...s/src/hardware-sim/BaseDeck/StagingAreaFixture.tsx 0.00% <ø> (ø)
...onents/src/hardware-sim/DeckConfigurator/index.tsx 70.96% <100.00%> (ø)
...ts/src/hardware-sim/BaseDeck/WasteChuteFixture.tsx 0.00% <0.00%> (ø)
components/src/molecules/LocationIcon/index.tsx 90.00% <0.00%> (ø)
...otocol-designer/src/components/DeckSetup/index.tsx 0.00% <0.00%> (ø)
components/src/hardware-sim/BaseDeck/BaseDeck.tsx 0.00% <0.00%> (ø)
...ware-sim/BaseDeck/WasteChuteStagingAreaFixture.tsx 0.00% <0.00%> (ø)

... and 879 files with indirect coverage changes

Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brenthagen brenthagen merged commit f5a99be into chore_release-7.1.0 Dec 15, 2023
49 of 50 checks passed
@brenthagen brenthagen deleted the components_base-deck-styling-adjustments branch December 15, 2023 19:21
ncdiehl11 pushed a commit that referenced this pull request Dec 20, 2023
adjusts BaseDeck styling of slot labels, staging area slot clip positioning, and colors to match
design system deck map

closes RAUT-902, RAUT-861
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants